appveyor: build test suite for coff32 by rainers · Pull Request #7968 · dlang/dmd

rainers · 2018-02-28T21:12:16Z

No description provided.

dlang-bot · 2018-02-28T21:12:17Z

Thanks for your pull request, @rainers!

Bugzilla references

Your PR doesn't reference any Bugzilla issue.

If your PR contains non-trivial changes, please reference a Bugzilla issue or create a manual changelog.

wilzbach · 2018-02-28T21:44:14Z

Looks like it's definitely worthwhile to do this:

Test runnable/test17559.d failed.  The logged output:
..\generated\Windows\Release\Win32\dmd.exe -conf= -m32mscoff -Irunnable -g    -odtest_m32mscoff\runnable -oftest_m32mscoff\runnable\test17559_0.exe  runnable\test17559.d  -map nul.map
test_m32mscoff\runnable\test17559_0.exe
object.Exception@runnable\test17559.d(48): fun
----------------
0x003DADEE in test17559 at C:\projects\dmd\test\runnable\test17559.d(48)
0x003DAD3B in D at C:\projects\dmd\test\runnable\test17559.d(32)
0x003DBE67 in void rt.dmain2._d_run_main(int, char**, extern (C) int function(char[][])*).runAll().__lambda1()
0x003DBDA9 in void rt.dmain2._d_run_main(int, char**, extern (C) int function(char[][])*).runAll()
0x003DBB68 in _d_run_main
0x003DB2BC in __entrypoint
0x0040CC8B in __scrt_common_main_seh at f:\dd\vctools\crt\vcstartup\src\startup\exe_common.inl(253)
0x76E77C04 in BaseThreadInitThunk
0x77D5AD8F in RtlInitializeExceptionChain
0x77D5AD5A in RtlInitializeExceptionChain
core.exception.AssertError@runnable\test17559.d(55): Assertion failure
----------------
0x003DB463 in _d_assertp
0x003DAD3B in D at C:\projects\dmd\test\runnable\test17559.d(32)
0x003DBE67 in void rt.dmain2._d_run_main(int, char**, extern (C) int function(char[][])*).runAll().__lambda1()
0x003DBDA9 in void rt.dmain2._d_run_main(int, char**, extern (C) int function(char[][])*).runAll()
0x003DBB68 in _d_run_main
0x003DB2BC in __entrypoint
0x0040CC8B in __scrt_common_main_seh at f:\dd\vctools\crt\vcstartup\src\startup\exe_common.inl(253)
0x76E77C04 in BaseThreadInitThunk
0x77D5AD8F in RtlInitializeExceptionChain
0x77D5AD5A in RtlInitializeExceptionChain

rainers · 2018-02-28T22:20:44Z

Looks like it's definitely worthwhile to do this:

That's the one fixed by dlang/druntime#2119.

skl131313 · 2018-03-02T11:42:23Z

Does the VisualD build for win32 use -m32 or -m32mscoff?

rainers · 2018-03-02T13:58:35Z

Does the VisualD build for win32 use -m32 or -m32mscoff?

It links with a VC built backend, so it has to use -m32mscoff.

JinShil · 2018-03-02T14:28:54Z

test/runnable/test15779.d


 void bar()
 {
+    version(CRuntime_Microsoft) {} else // TODO: fails for -O -inline, also disabled for the auto-tester


What's the problem here? What's the plan for eventually enabling it for the auto tester? Is a bug report filed for it?

Not sure, maybe related: https://issues.dlang.org/show_bug.cgi?id=13821 and https://issues.dlang.org/show_bug.cgi?id=16511.
I have added a new one: https://issues.dlang.org/show_bug.cgi?id=18547

In that case I recommend adding links to those issues in the comments and come clean about your understanding of what's going on. Something like:

"Fibers appear to be broken in Windows. We don't yet have a solution, see these issues...." or something like that. My motivations is to ensure that there is some kind of "paper trail" that one can follow to eventually solve the issue.

I agree with the "paper trail" proposal, otherwise such comments just mystify the reader.

@rainers my guess is that this test passes on LDC. Can you scope this to CRuntime_Microsoft and DigitalMars (i.e. dmd)?

I think I figured it out: dlang/druntime#2129. All windows builds should be affected, but happens spuriously.

I have removed the workaround in the hope that the bugfix will be accepted.

skl131313 · 2018-03-03T02:31:24Z

Using DISABLED: win32 in the test settings at the top would help for that a bit, so that the test output doesn't show it's successful rather than being skipped.

rainers · 2018-03-04T09:34:39Z

Appveyor even passed without dlang/druntime#2129, but I guess that can change spuriously (but also for the Win64 check on Appveyor or the Windows checks on the auto tester).

JinShil · 2018-03-07T04:46:16Z

Restarted Semaphore CI. All CIs are passing now.

rainers force-pushed the appveyor_coff32 branch 5 times, most recently from bac79e2 to 8cace70 Compare March 1, 2018 09:55

JinShil approved these changes Mar 2, 2018

View reviewed changes

JinShil reviewed Mar 2, 2018

View reviewed changes

JinShil added the Infrastructure:Continuous Integration label Mar 4, 2018

appveyor: build test suite for coff32

879a22a

rainers force-pushed the appveyor_coff32 branch from 8cace70 to 879a22a Compare March 4, 2018 09:02

PetarKirov approved these changes Mar 9, 2018

View reviewed changes

PetarKirov added the Merge:auto-merge label Mar 9, 2018

dlang-bot merged commit 6e4a756 into dlang:master Mar 9, 2018

Uh oh!

Conversation

rainers commented Feb 28, 2018

Uh oh!

dlang-bot commented Feb 28, 2018

Bugzilla references

Uh oh!

wilzbach commented Feb 28, 2018

Uh oh!

rainers commented Feb 28, 2018

Uh oh!

skl131313 commented Mar 2, 2018

Uh oh!

rainers commented Mar 2, 2018

Uh oh!

JinShil Mar 2, 2018

Choose a reason for hiding this comment

Uh oh!

rainers Mar 2, 2018

Choose a reason for hiding this comment

Uh oh!

JinShil Mar 3, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

WalterBright Mar 3, 2018

Choose a reason for hiding this comment

Uh oh!

PetarKirov Mar 4, 2018

Choose a reason for hiding this comment

Uh oh!

rainers Mar 4, 2018

Choose a reason for hiding this comment

Uh oh!

rainers Mar 4, 2018

Choose a reason for hiding this comment

Uh oh!

PetarKirov Mar 4, 2018

Choose a reason for hiding this comment

Uh oh!

skl131313 commented Mar 3, 2018

Uh oh!

rainers commented Mar 4, 2018

Uh oh!

JinShil commented Mar 7, 2018

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

JinShil Mar 3, 2018 •

edited

Loading